sfc-gh-emaynard commented on code in PR #1068:
URL: https://github.com/apache/polaris/pull/1068#discussion_r1978407753
##########
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfiguration.java:
##########
@@ -264,4 +264,11 @@ public static <T> Builder<T> builder() {
+ STORAGE_CREDENTIAL_DURATION_SECONDS.key)
.defaultValue(30 * 60) // 30 minutes
.build();
+
+ public static final PolarisConfiguration<Integer>
STORAGE_CONFIGURATION_MAX_LOCATIONS =
+ PolarisConfiguration.<Integer>builder()
+ .key("STORAGE_CONFIGURATION_MAX_LOCATIONS")
+ .description("How many locations can be associated with a storage
configuration")
+ .defaultValue(20)
Review Comment:
I added support for -1 for no limit... I think marking it as deprecated
could be confusing.
I also added a per-catalog config (not application level) so you can have
different limits e.g. per cloud or per catalog. In the future, we've also
thought about putting these configs on the namespace level.
Are we all okay with a single limit for now, with the option to add more
later?
Alternatively, we could go ahead with no limit, with the commitment that if
we later add a limit we'll default it to -1.
##########
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfiguration.java:
##########
@@ -264,4 +264,11 @@ public static <T> Builder<T> builder() {
+ STORAGE_CREDENTIAL_DURATION_SECONDS.key)
.defaultValue(30 * 60) // 30 minutes
.build();
+
+ public static final PolarisConfiguration<Integer>
STORAGE_CONFIGURATION_MAX_LOCATIONS =
+ PolarisConfiguration.<Integer>builder()
+ .key("STORAGE_CONFIGURATION_MAX_LOCATIONS")
+ .description("How many locations can be associated with a storage
configuration")
+ .defaultValue(20)
Review Comment:
I added support for -1 for no limit... I think marking it as deprecated
could be confusing.
I also added a per-catalog config (not application level) so you can have
different limits e.g. per cloud or per catalog. In the future, we've also
thought about putting these configs on the namespace level.
Are we all okay with a single limit for now, with the option to add more
later?
Alternatively, we could go ahead with no limit, with the commitment that if
we later add a limit we'll default it to -1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
