eric-maynard commented on code in PR #1105:
URL: https://github.com/apache/polaris/pull/1105#discussion_r1978417037
##########
service/common/src/main/java/org/apache/polaris/service/exception/IcebergExceptionMapper.java:
##########
@@ -166,12 +166,15 @@ public static Collection<String> getAccessDeniedHints() {
static int mapExceptionToResponseCode(RuntimeException rex) {
// Cloud exceptions
- if (rex instanceof S3Exception
- || rex instanceof AzureException
- || rex instanceof StorageException) {
+ if (isCloudException(rex)) {
return mapCloudExceptionToResponseCode(rex);
}
+ Throwable rootCause = ExceptionUtils.getRootCause(rex);
Review Comment:
I vaguely remember this coming up before, but I suspect we should inspect
the entire cause chain rather than just the root cause
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
