dimas-b commented on code in PR #1107:
URL: https://github.com/apache/polaris/pull/1107#discussion_r1978551896
##########
service/common/src/main/java/org/apache/polaris/service/catalog/IcebergCatalogAdapter.java:
##########
@@ -459,6 +461,25 @@ public Response listViews(
.build();
}
+ @Override
+ public Response loadCredentials(
+ String prefix,
+ String namespace,
+ String table,
+ RealmContext realmContext,
+ SecurityContext securityContext) {
+ Namespace ns = decodeNamespace(namespace);
+ TableIdentifier tableIdentifier = TableIdentifier.of(ns,
RESTUtil.decodeString(table));
+ LoadTableResponse loadTableResponse =
+ newHandlerWrapper(realmContext, securityContext, prefix)
+ .loadTableWithAccessDelegation(tableIdentifier, "ALL");
Review Comment:
Iceberg REST API spec appears to require the snapshots parameter to be lower
case, i.e. `all`:
https://github.com/apache/polaris/blob/main/spec/iceberg-rest-catalog-open-api.yaml#L948
##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationTest.java:
##########
@@ -1012,4 +1012,26 @@ public void testRenameViewStatus() {
assertThat(response).returns(Response.Status.NO_CONTENT.getStatusCode(),
Response::getStatus);
}
}
+
+ @Test
+ public void testLoadCredentials() {
+ String tableName = "tbl1";
+ Namespace namespace = Namespace.of("ns1");
+ TableIdentifier identifier = TableIdentifier.of(namespace, tableName);
+
+ if (requiresNamespaceCreate()) {
Review Comment:
nit: Isn't this always `true` for Polaris?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
