eric-maynard commented on code in PR #1037:
URL: https://github.com/apache/polaris/pull/1037#discussion_r1981899558
##########
service/common/src/main/java/org/apache/polaris/service/catalog/IcebergCatalogAdapter.java:
##########
@@ -331,24 +336,32 @@ public Response loadTable(
String namespace,
String table,
String accessDelegationMode,
+ String ifNoneMatchHeader,
String snapshots,
RealmContext realmContext,
SecurityContext securityContext) {
EnumSet<AccessDelegationMode> delegationModes =
parseAccessDelegationModes(accessDelegationMode);
Namespace ns = decodeNamespace(namespace);
TableIdentifier tableIdentifier = TableIdentifier.of(ns,
RESTUtil.decodeString(table));
- if (delegationModes.isEmpty()) {
- return Response.ok(
- newHandlerWrapper(realmContext, securityContext, prefix)
- .loadTable(tableIdentifier, snapshots))
- .build();
- } else {
- return Response.ok(
- newHandlerWrapper(realmContext, securityContext, prefix)
- .loadTableWithAccessDelegation(tableIdentifier, snapshots))
+ ETaggedResponse<LoadTableResponse> loadTableResult;
+
+ IfNoneMatch ifNoneMatch = IfNoneMatch.fromHeader(ifNoneMatchHeader);
+
+ if (ifNoneMatch.isWildcard())
+ throw new BadRequestException("If-None-Match may not take the value of
'*'");
Review Comment:
Let's use braces here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
