eric-maynard commented on code in PR #1115:
URL: https://github.com/apache/polaris/pull/1115#discussion_r1981916831
##########
regtests/client/python/cli/polaris_cli.py:
##########
@@ -144,20 +144,23 @@ def _get_client_builder(options):
polaris_catalog_url = f'http://{host}:{port}/api/catalog/v1'
builder = None
+ config = Configuration(host=polaris_management_url)
+ if options.proxy:
+ config.proxy = options.proxy
if has_access_token:
- builder = lambda: ApiClient(
- Configuration(host=polaris_management_url,
access_token=options.access_token),
- )
+ config.access_token = options.access_token
+ builder = lambda: ApiClient(config)
elif has_client_secret:
- builder = lambda: ApiClient(
- Configuration(host=polaris_management_url, username=client_id,
password=client_secret),
- )
+ config.username = client_id
+ config.password = client_secret
+ builder = lambda: ApiClient(config)
Review Comment:
Since all the branches now define `builder` the same way, can we remove the
repeated code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
