eric-maynard commented on code in PR #1125: URL: https://github.com/apache/polaris/pull/1125#discussion_r1982288807
########## getting-started/eclipselink/docker-compose.yml: ########## @@ -49,10 +49,27 @@ services: timeout: 10s retries: 10 + polaris-purge: + # IMPORTANT: the image MUST contain the Postgres JDBC driver and EclipseLink dependencies, see README for instructions + image: apache/polaris-admin-tool:postgres-latest + depends_on: + postgres: + condition: service_started + environment: + polaris.persistence.type: eclipse-link + polaris.persistence.eclipselink.configuration-file: /deployments/config/eclipselink/persistence.xml + volumes: + - ../assets/eclipselink/:/deployments/config/eclipselink + command: + - "purge" + - "--realm=POLARIS" Review Comment: Is there a way we can have it still fail if you need purge, but we allow you to re-run docker with some simple flag that causes the purge command to run? That way we don't risk someone accidentally purging, but we still improve the frustrating UX you describe. If not, I am ok to go forward with the PR as written. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org