eric-maynard commented on code in PR #1124: URL: https://github.com/apache/polaris/pull/1124#discussion_r1988420986
########## polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java: ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.config; + +import java.util.Optional; + +/** + * Configurations for non-feature beheavior changes within Polaris. These configurations are not + * intended for use by end users and govern nuanced behavior changes and bugfixes. The + * configurations never expose user-facing catalog-level configurations. These configurations are + * not stable and may be removed at any time. + * + * @param <T> The type of the configuration + */ +public class BehaviorChangeConfiguration<T> extends PolarisConfiguration<T> { Review Comment: Looking at that example, I think it functions the way we should want it to. I created a test with a consumer like this: ``` private static class PolarisConfigurationConsumer { ... public <T> T consumeConfiguration(PolarisConfiguration<Boolean> config, Supplier<T> code, T defaultVal) { if (configurationStore.getConfiguration(polarisCallContext, config)) { return code.get(); } return defaultVal; } } ``` Where it's used like: ``` @Test public void testBehaviorAndFeatureConfigs() { ... FeatureConfiguration<Integer> featureConfig = PolarisConfiguration.<Integer>builder() ... .buildFeatureConfiguration(); BehaviorChangeConfiguration<Boolean> behaviorChangeConfig = PolarisConfiguration.<Boolean>builder() ... .buildBehaviorChangeConfiguration(); consumer.consumeConfiguration(behaviorChangeConfig, () -> 21, 22); consumer.consumeConfiguration(featureConfig, () -> 21, 22); } ``` As expected, that last line won't compile because the method expects a PolarisConfiguration<**Boolean**>. If featureConfig is changed to a FeatureConfiguration<Boolean>, everything works as expected. I'll commit the test in that state now, but let me know how we can adjust it to better suit the use case you had in mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
