sfc-gh-dhuo commented on code in PR #1139:
URL: https://github.com/apache/polaris/pull/1139#discussion_r1987787328
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java:
##########
@@ -80,14 +85,20 @@ void writeEntity(
* <p>TODO: Push down the multi-entity commit from
PolarisMetaStoreManagerImpl to use this instead
* of running single writeEntity actions within a transaction.
*
+ * <p>TODO: Change originalEntity to be just the set of members taht
participate in conditions,
+ * similar to PolarisEntityCore, and make the callsites in
BasePolarisCatalog actually plumb
+ * through correctly, in particular for values the
PolarisMetaStoreManagerImpl doesn't have access
+ * to such as the original name and parentId in renames.
+ *
* @param callCtx call context
* @param entities entities to persist
* @param originalEntities original states of the entity to use for
compare-and-swap purposes, or
* null if this is expected to be a brand-new entity; must contain
exactly as many elements as
* {@code entities} where each item corresponds to the element of {@code
entities} in the same
- * index as this list.
+ * index as this list. If non-null, we expect all elements of
originalEntities to be non-null;
+ * there is no mix-and-match "create" and "update" in a single batch.
Review Comment:
From discussion, we should tighten up this interface, at least in the
javadoc comment before merging -- allow only entities that are in the same
"concern/scoping" as in intra-catalog entities are one concern vs
principals/principal-roles are a different one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
