gh-yzou commented on code in PR #1150:
URL: https://github.com/apache/polaris/pull/1150#discussion_r1992374370
##########
spec/polaris-catalog-service.yaml:
##########
@@ -127,13 +127,21 @@ paths:
# /v1/{prefix}/namespaces/{namespace}/tables/{table}/tasks:
# Not implemented in Polaris
- ######################
- # Polaris-native API #
- ######################
+ ############################
+ # Polaris Notification API #
+ ############################
/v1/{prefix}/namespaces/{namespace}/tables/{table}/notifications:
$ref:
'./polaris-catalog-apis/notifications-api.yaml#/paths/~1v1~1{prefix}~1namespaces~1{namespace}~1tables~1{table}~1notifications'
+ #############################
+ # Polaris Generic Table API #
+ #############################
+ /polaris/v1/{prefix}/namespaces/{namespace}/generic-tables:
+ $ref:
'./polaris-catalog-apis/generic-tables-api.yaml#/paths/~1polaris~1v1~1{prefix}~1namespaces~1{namespace}~1generic-tables'
+
+ /polaris/v1/{prefix}/namespaces/{namespace}/generic-tables/{generic-table}:
+ $ref:
'./polaris-catalog-apis/generic-tables-api.yaml#/paths/~1polaris~1v1~1{prefix}~1namespaces~1{namespace}~1generic-tables~1{generic-table}'
Review Comment:
That is a good question. In fact, @HonahX is going to carry out a
discussion about this later about do we want to have an independent service
file for the APIs under new prefix.
I think we can keep this discussion separate with this PR, and if we decided
to do that, we can just have one pr to put all new definitions to a separate
service file, and there is some other things like (auth definition) need to be
take care of, so that we can keep the purpose of each pr more clear. Meanwhile
@HonahX and I can carry this discussion independently soon. Would that work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
