HonahX commented on code in PR #808:
URL: https://github.com/apache/polaris/pull/808#discussion_r1992452120
##########
spec/polaris-catalog-service.yaml:
##########
@@ -127,13 +127,29 @@ paths:
# /v1/{prefix}/namespaces/{namespace}/tables/{table}/tasks:
# Not implemented in Polaris
- ######################
- # Polaris-native API #
- ######################
+ ############################
+ # Polaris Notification API #
+ ############################
/v1/{prefix}/namespaces/{namespace}/tables/{table}/notifications:
$ref:
'./polaris-catalog-apis/notifications-api.yaml#/paths/~1v1~1{prefix}~1namespaces~1{namespace}~1tables~1{table}~1notifications'
+ ######################
+ # Polaris Policy API #
+ ######################
+
+ /polaris/v1/{prefix}/namespaces/{namespace}/policies:
+ $ref:
'./polaris-catalog-apis/policy-apis.yaml#/paths/~1polaris~1v1~1{prefix}~1namespaces~1{namespace}~1policies'
+
+ /polaris/v1/{prefix}/namespaces/{namespace}/policies/{policyName}:
+ $ref:
'./polaris-catalog-apis/policy-apis.yaml#/paths/~1polaris~1v1~1{prefix}~1namespaces~1{namespace}~1policies~1{policyName}'
+
+ /polaris/v1/{prefix}/namespaces/{namespace}/policies/{policyName}/mappings:
+ $ref:
'./polaris-catalog-apis/policy-apis.yaml#/paths/~1polaris~1v1~1{prefix}~1namespaces~1{namespace}~1policies~1{policyName}~1mappings'
+
+ /polaris/v1/{prefix}/applicablePolicies:
+ $ref:
'./polaris-catalog-apis/policy-apis.yaml#/paths/~1polaris~1v1~1{prefix}~1applicablePolicies'
Review Comment:
Hi @collado-mike, similar to
https://github.com/apache/polaris/pull/1150#discussion_r1992383764, I currently
put here to make sure we do not duplicate servers and security schemes
definition. And this also means we can easily render a preview of all supported
API like
https://editor-next.swagger.io/?url=https://raw.githubusercontent.com/HonahX/polaris/refs/heads/honahx_policy_management_apis/spec/generated/bundled-polaris-catalog-service.yaml
But I agree there are also advantages of the alternative approach. How about
we discuss that in a follow-up and do a refactor as a whole once generic table
api and policy api are all in? We can re-organize these files any time if
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
