wolflex888 commented on code in PR #1164:
URL: https://github.com/apache/polaris/pull/1164#discussion_r1992294204


##########
service/common/src/main/java/org/apache/polaris/service/catalog/PolarisCatalogHandlerWrapper.java:
##########
@@ -877,15 +883,22 @@ public LoadTableResponse loadTableWithAccessDelegation(
                   credentialDelegation.getCredentialConfig(
                       tableIdentifier, tableMetadata, actionsRequested));
             }
-            return responseBuilder.build();
+            
if(accessDelegationModes.contains(AccessDelegationMode.VENDED_CREDENTIALS)){
+              try {
+                String hostName = 
InetAddress.getLocalHost().getCanonicalHostName();

Review Comment:
   Is there a better way to grab the server host here? I don't think this is 
reliable but I do not know a better way to get the host. Potentially, we can 
get it from the request header? but it looks like the headers are being 
filtered out.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to