dimas-b commented on code in PR #1170:
URL: https://github.com/apache/polaris/pull/1170#discussion_r1994204914
##########
polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java:
##########
@@ -37,6 +37,7 @@ protected BehaviorChangeConfiguration(
super(key, description, defaultValue, catalogConfig);
}
+ @BehaviorChangeConfigurationSince("1.0.0")
public static final BehaviorChangeConfiguration<Boolean>
VALIDATE_VIEW_LOCATION_OVERLAP =
PolarisConfiguration.<Boolean>builder()
.key("STORAGE_CREDENTIAL_CACHE_DURATION_SECONDS")
Review Comment:
Unrelated, but the key appears to be wrong?
##########
polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfigurationSince.java:
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.core.config;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+/**
+ * An annotation for BehaviorChangeConfiguration instances that should be
applied to all instances.
Review Comment:
All instances of what?
##########
polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java:
##########
@@ -37,6 +37,7 @@ protected BehaviorChangeConfiguration(
super(key, description, defaultValue, catalogConfig);
}
+ @BehaviorChangeConfigurationSince("1.0.0")
public static final BehaviorChangeConfiguration<Boolean>
VALIDATE_VIEW_LOCATION_OVERLAP =
Review Comment:
I'm not sure I understand how this annotation is supposed to work :thinking:
So, when 1.0.3 is released, this flag will have to be removed, right? Does
this mean that view location overlaps will not be validated in 1.0.3? If so,
why are they validated now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
