dimas-b commented on code in PR #1166:
URL: https://github.com/apache/polaris/pull/1166#discussion_r1996201481
##########
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java:
##########
@@ -98,26 +99,42 @@ public PolarisEclipseLinkMetaStoreSessionImpl(
@Nullable String confFile,
@Nullable String persistenceUnitName,
@Nonnull PrincipalSecretsGenerator secretsGenerator) {
+ this(
+ createEntityManagerFactory(realmContext, confFile,
persistenceUnitName),
+ store,
+ storageIntegrationProvider,
+ secretsGenerator);
LOGGER.debug(
"Creating EclipseLink Meta Store Session for realm {}",
realmContext.getRealmIdentifier());
Review Comment:
Java does not allow plain code statements before `this()` or `super()`.
@flyrain : Are you ok to merge like this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
