eric-maynard commented on PR #1128: URL: https://github.com/apache/polaris/pull/1128#issuecomment-2730005067
Isn’t there a thread from 3/6 already? On Mon, Mar 17, 2025 at 7:52 AM Robert Stupp ***@***.***> wrote: > Can you point out in the code where "exposes persistence internals and > pushes those things up to the call sites"? I'm also open for suggestion how > we can separate concern better. > > Sure, as mentioned elsewhere, there should eventually be distinct APIs for > each concern. Those APIs do not have to and therefore must not deal for > example with persistence-internal IDs or dictate how objects are stored but > provide the "concern specific" operations. > > As that's a more general approach, I really prefer to move this one into > draft state and discuss the approach on the dev-ML. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/polaris/pull/1128#issuecomment-2729817856>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AFRE3SA3HOD77KDTYF7RGHL2U3OUTAVCNFSM6AAAAABYOAQGR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRZHAYTOOBVGY> > . > You are receiving this because your review was requested.Message ID: > ***@***.***> > [image: snazy]*snazy* left a comment (apache/polaris#1128) > <https://github.com/apache/polaris/pull/1128#issuecomment-2729817856> > > Can you point out in the code where "exposes persistence internals and > pushes those things up to the call sites"? I'm also open for suggestion how > we can separate concern better. > > Sure, as mentioned elsewhere, there should eventually be distinct APIs for > each concern. Those APIs do not have to and therefore must not deal for > example with persistence-internal IDs or dictate how objects are stored but > provide the "concern specific" operations. > > As that's a more general approach, I really prefer to move this one into > draft state and discuss the approach on the dev-ML. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/polaris/pull/1128#issuecomment-2729817856>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AFRE3SA3HOD77KDTYF7RGHL2U3OUTAVCNFSM6AAAAABYOAQGR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRZHAYTOOBVGY> > . > You are receiving this because your review was requested.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
