andrew4699 commented on code in PR #922: URL: https://github.com/apache/polaris/pull/922#discussion_r2001545021
########## service/common/src/main/java/org/apache/polaris/service/events/AfterTableCommitedEvent.java: ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.events; + +import org.apache.iceberg.TableMetadata; + +/** + * Emitted after Polaris performs a commit to a table. This is not emitted if there's an exception + * while committing. + * + * @param base The old metadata. + * @param metadata The new metadata. + */ +public record AfterTableCommitedEvent(TableMetadata base, TableMetadata metadata) Review Comment: Great catch, added! ########## service/common/src/main/java/org/apache/polaris/service/events/AfterViewCommitedEvent.java: ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.events; + +import org.apache.iceberg.view.ViewMetadata; + +/** + * Emitted after Polaris performs a commit to a view. This is not emitted if there's an exception + * while committing. + * + * @param base The old metadata. + * @param metadata The new metadata. + */ +public record AfterViewCommitedEvent(ViewMetadata base, ViewMetadata metadata) Review Comment: Great catch, added! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
