snazy commented on PR #1190: URL: https://github.com/apache/polaris/pull/1190#issuecomment-2735748542
Summary of the system-properties approach and Nessie's approach: | Topic| System Properties | Nessie's approach | |---|---|---| | CI | Requires additional workflow | No additional workflow | | GitHub req checks | Requires additional, manual work because of WF matrix | No additional steps needed | | BOM | Requires Gradle magic to integrate it | No Gradle magic needed for the BOM | | Releases | Requires additional steps, risk of not publishing/releasing the right artifacts and risk of publishing/releasing not all artifacts | No additional steps needed | | DevEx | Requires additional, manual steps to run `check` against all versions | No additional/manual steps needed | As you can see, the system properties approach is way more error prone. We have already seen that Iceberg releases published the wrong artifacts - and part of the reason was the exactly the "system properties approach". Also look at how Iceberg releases work - that's quite some additional code and "magic" that requires its own hard to test code. Emphasizing: **There is no CI for releases!** Therefore I'm definitely -1 on the system properties approach, because I do not want to unnecessarily complicate CI, GH setup, BOM, releases and DevEx. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
