pingtimeout commented on code in PR #1208:
URL: https://github.com/apache/polaris/pull/1208#discussion_r2003670114
##########
.scalafmt.conf:
##########
@@ -0,0 +1,25 @@
+# Scalafmt is used to reformat Gatling benchmarks from the benchmarks/
directory
Review Comment:
I am ok with replacing that with anything. To be honest, I just did not
want to care about any formatting concern while I was working on benchmarks. I
understand that the rules in that scalafmt config file could be very different
from those adopted by Polaris.
##########
gradle/projects.main.properties:
##########
@@ -36,6 +36,7 @@ aggregated-license-report=aggregated-license-report
polaris-immutables=tools/immutables
polaris-container-spec-helper=tools/container-spec-helper
polaris-version=tools/version
+polaris-benchmarks=benchmarks
Review Comment:
It could be. I am also considering removing the `Iceberg` mention from the
benchmarks folder altogether as the benchmarks also relies on the Management
API, and is not just an Iceberg REST API benchmark. Let's wait until we reach
consensus on where the benchmarks should live before we move this around though.
##########
getting-started/assets/polaris/create-catalog.sh:
##########
@@ -50,7 +50,7 @@ curl -s -H "Authorization: Bearer ${token}" \
"storageConfigInfo": {
"storageType": "FILE",
"allowedLocations": [
- "file:///tmp"
+ "file:///tmp/polaris/"
Review Comment:
Kind of. That one is a bit of a 🥷. The current getting-started code
prevents any catalog to be created under `/tmp/` altogether, even though a
single catalog is created under `/tmp/polaris`. See L48 of this file.
Updating the allowedLocations attribute to match that of the catalog makes it
possible to created any number of catalogs under `/tmp/`.
##########
benchmarks/build.gradle.kts:
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+plugins {
+ id("scala")
+ id("io.gatling.gradle") version "3.13.4.1"
+ id("com.diffplug.spotless")
+}
+
+dependencies {
+ gatling("com.typesafe.play:play-json_2.13:2.9.4")
+}
+
+description = "Polaris Iceberg REST API performance tests"
+
+spotless {
+ scala {
+ // Use scalafmt for Scala formatting
+ scalafmt("3.9.3").configFile("../.scalafmt.conf")
+ }
+}
Review Comment:
Do you think there should be a `polaris-scala.gradle.kts` file? I wouldn't
mind adding `polaris-server` there, really. But the code does not strictly
depend on Polaris server. It might actually be moved to the tools repository
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
