dimas-b commented on code in PR #1215:
URL: https://github.com/apache/polaris/pull/1215#discussion_r2005846156
##########
service/common/src/main/java/org/apache/polaris/service/catalog/PolarisCatalogHandlerWrapper.java:
##########
@@ -1019,88 +1016,86 @@ public void commitTransaction(CommitTransactionRequest
commitTransactionRequest)
throw new BadRequestException("Cannot update table on external
catalogs.");
}
- if (!(baseCatalog instanceof BasePolarisCatalog)) {
+ if (baseCatalog instanceof BasePolarisCatalog basePolarisCatalog) {
Review Comment:
Blocking this particular coding option does not sound good to me. I believe
it is quite valid to use negative `instanceof` checks in `if` conditions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
