XJDKC commented on code in PR #1191:
URL: https://github.com/apache/polaris/pull/1191#discussion_r2006353669
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java:
##########
@@ -240,6 +246,21 @@ public Builder setStorageConfigurationInfo(
}
allowedLocations.add(defaultBaseLocation);
validateMaxAllowedLocations(allowedLocations);
+
+ PolarisStorageConfigurationInfo existingConfig = null;
Review Comment:
The logic is currently in the CatalogEntity builder, for the builder, it
doesn't have the catalog entity but just an internalProperties map. I'm trying
to get the storage config from the internal properties map. Do you mean I need
to implement a method like this:
```java
class CatalogDao {
PolarisStorageConfigurationInfo getExistingStorageConfig(Map<String,
String> internalProperties) {
}
}
```
Or it's better to just put it in the CatalogEntity class as a static method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
