flyrain commented on code in PR #1238: URL: https://github.com/apache/polaris/pull/1238#discussion_r2008632077
########## polaris-core/src/main/java/org/apache/polaris/core/policy/validator/DataCompactionPolicyValidator.java: ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.policy.validator; + +import static org.apache.polaris.core.entity.PolarisEntityType.CATALOG; +import static org.apache.polaris.core.entity.PolarisEntityType.ICEBERG_TABLE_LIKE; +import static org.apache.polaris.core.entity.PolarisEntityType.NAMESPACE; + +import com.google.common.base.Strings; +import java.util.Set; +import org.apache.polaris.core.entity.PolarisEntitySubType; +import org.apache.polaris.core.entity.PolarisEntityType; + +public class DataCompactionPolicyValidator implements PolicyValidator<DataCompactionPolicy> { + static final DataCompactionPolicyValidator INSTANCE = new DataCompactionPolicyValidator(); + + private static final String DEFAULT_POLICY_SCHEMA_VERSION = "2025-02-03"; + private static final Set<String> POLICY_SCHEMA_VERSIONS = Set.of(DEFAULT_POLICY_SCHEMA_VERSION); + private static final Set<PolarisEntityType> ATTACHABLE_ENTITY_TYPES = + Set.of(CATALOG, NAMESPACE, ICEBERG_TABLE_LIKE); + + @Override + public DataCompactionPolicy parse(String content) { + if (Strings.isNullOrEmpty(content)) { + throw new InvalidPolicyException("Policy is empty"); + } + + try { + var policy = PolicyValidatorUtil.MAPPER.readValue(content, DataCompactionPolicy.class); + if (policy == null) { + throw new InvalidPolicyException("Invalid policy"); + } + + if (Strings.isNullOrEmpty(policy.getVersion())) { + policy.setVersion(DEFAULT_POLICY_SCHEMA_VERSION); + } + + if (!POLICY_SCHEMA_VERSIONS.contains(policy.getVersion())) { + throw new InvalidPolicyException("Invalid policy version: " + policy.getVersion()); + } + Review Comment: We cannot know the semantic within the config map. User can give a string to `target_file_size_bytes`, it should still be acceptable, as `target_file_size_bytes` doesn't mean anything in the schema. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
