flyrain commented on code in PR #1238: URL: https://github.com/apache/polaris/pull/1238#discussion_r2012922243
########## polaris-core/src/main/java/org/apache/polaris/core/policy/validator/PolicyValidator.java: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.policy.validator; + +import org.apache.polaris.core.entity.PolarisEntitySubType; +import org.apache.polaris.core.entity.PolarisEntityType; + +/** + * Validates and parses a given policy content string against its defined schema. + * + * @param <T> the type of policy object to be returned after validation + */ +public interface PolicyValidator<T> { + + /** + * Parses and validates the provided policy content. + * + * @param content the policy content to parse and validate + * @return a policy object of type T if the content is valid + * @throws InvalidPolicyException if the content does not meet the required policy rules + */ + T parse(String content) throws InvalidPolicyException; Review Comment: > It looks like this is primarily a parser, not a validator if it's turning a string into a policy type. Separated the parsing and validating in the new commit. The parsing is with the policy content class now. Added a marker interface `PolicyContent`. `fromString()` is a static method, so I didn't use this pattern, https://en.wikipedia.org/wiki/Curiously_recurring_template_pattern. We could have a pattern like `Policy<T extends Policy<T>>` once we need a inheritable method that could return a subtype. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
