singhpk234 commented on code in PR #1274:
URL: https://github.com/apache/polaris/pull/1274#discussion_r2021853423


##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java:
##########
@@ -37,6 +37,11 @@
  * defining the internal data model for Polaris, and which defines the basis 
for the RBAC model
  * provided by Polaris.
  *
+ * <p>Each method in this interface must be atomic, meaning that write 
operations must either fully
+ * succeed with all changes applied, or fail entirely without any side effects 
or partial updates.
+ * Read operations must return a consistent view of the data as it existed at 
a specific point in

Review Comment:
   For things like listEntities, it will be very tricky considering  as 
presently we do client side filtering because the only option left will be to 
do is load all the entities without any limit in the client which can be huge 
and then filter the stuff from the client side filtering. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to