liamzwbao commented on code in PR #1289:
URL: https://github.com/apache/polaris/pull/1289#discussion_r2025703331
##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogTest.java:
##########
@@ -386,18 +386,27 @@ public Map<String, BaseResult>
purgeRealms(Iterable<String> realms) {
};
}
- /** TODO: Unblock this test, see:
https://github.com/apache/polaris/issues/1272 */
@Override
@Test
- @Disabled(
- """
- Disabled because the behavior is not applicable to Polaris.
- To unblock:
- 1) Align Polaris behavior with the superclass by handling empty
namespaces the same way, or
- 2) Modify this test to expect an exception and add a Polaris-specific
version.
- """)
public void listNamespacesWithEmptyNamespace() {
- super.listNamespacesWithEmptyNamespace();
+ // In Polaris, the empty namespace implicitly exists by default.
+ // The superclass test assumes the empty namespace does not exist
initially,
+ // so running it will fail as expected.
+ Assertions.assertThatThrownBy(super::listNamespacesWithEmptyNamespace)
+ .isInstanceOf(AssertionFailedError.class);
+ }
+
+ @Test
+ public void listNamespacesWithEmptyNamespaceInPolaris() {
+ catalog().createNamespace(NS);
+
+
Assertions.assertThat(catalog().namespaceExists(Namespace.empty())).isTrue();
+ Assertions.assertThat(catalog().listNamespaces())
+ .contains(NS)
+ .doesNotContain(Namespace.empty());
Review Comment:
One interesting behavior is that we can drop the empty namespace using
`catalog().dropNamespace(Namespace.empty())`. But after doing that, we can’t
create any new namespaces because it fails, saying the parent namespace doesn't
exist. Even worse, we also can’t recreate the empty namespace itself since it's
explicitly blocked
[here](https://github.com/apache/polaris/blob/8b5dfa97a8e50a53412d2ded40f2e4db5a40cc42/service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java#L490-L493).
I think we should consider aligning the behavior between creating and
dropping the empty namespace anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
