eric-maynard commented on code in PR #1298:
URL: https://github.com/apache/polaris/pull/1298#discussion_r2028090363
##########
service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##########
@@ -472,11 +471,7 @@ private void authorizeGrantOnTableLikeOperationOrThrow(
throw new NotFoundException("Catalog not found: %s", catalogName);
} else if (status.getStatus() ==
ResolverStatus.StatusEnum.PATH_COULD_NOT_BE_FULLY_RESOLVED) {
if (status.getFailedToResolvePath().getLastEntityType() ==
PolarisEntityType.TABLE_LIKE) {
- if (subType == PolarisEntitySubType.ICEBERG_TABLE) {
- throw new NoSuchTableException("Table does not exist: %s",
identifier);
- } else {
- throw new NoSuchViewException("View does not exist: %s", identifier);
- }
+ CatalogHandler.throwNotFoundException(identifier, subType);
Review Comment:
> when isTable is True, we can throw, no Iceberg or Generic Table is found.
At least for the catalog methods, we need to exactly match the error
messages expected by Iceberg. More generally, it's not a great idea to change
these messages if we can help it. If ANY_SUBTYPE is never passed in here (and
it shouldn't be) the messages are correct
##########
service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##########
@@ -472,11 +471,7 @@ private void authorizeGrantOnTableLikeOperationOrThrow(
throw new NotFoundException("Catalog not found: %s", catalogName);
} else if (status.getStatus() ==
ResolverStatus.StatusEnum.PATH_COULD_NOT_BE_FULLY_RESOLVED) {
if (status.getFailedToResolvePath().getLastEntityType() ==
PolarisEntityType.TABLE_LIKE) {
- if (subType == PolarisEntitySubType.ICEBERG_TABLE) {
- throw new NoSuchTableException("Table does not exist: %s",
identifier);
- } else {
- throw new NoSuchViewException("View does not exist: %s", identifier);
- }
+ CatalogHandler.throwNotFoundException(identifier, subType);
Review Comment:
But if we want to change the message, then I think the existing check can
work with a slight change to the `else` condition. Ideally we would pass in the
subtype here, but that would require refactors to `TableGrant` which could be a
bit unnecessarily invasive just for an error message. Let me try that way first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
