dimas-b commented on code in PR #1287:
URL: https://github.com/apache/polaris/pull/1287#discussion_r2029474857


##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/RelationalJdbcConfiguration.java:
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.extension.persistence.relational.jdbc;
+
+import io.quarkus.runtime.annotations.StaticInitSafe;
+import io.smallrye.config.ConfigMapping;
+import java.util.Optional;
+
+@StaticInitSafe
+@ConfigMapping(prefix = "polaris.persistence.relational")
+public interface RelationalJdbcConfiguration {

Review Comment:
   Sorry, I should have commented about Quarkus support for DataSources before 
(see my other comment). If that works, all this config can be delegated to 
Quarkus, I think.... Essentially this PR would become redundant... Why not 
repurpose this PR and put all of `relational-jdbc` code here?
   
   



##########
extension/persistence/relational-jdbc/build.gradle.kts:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+plugins {
+  id("polaris-server")
+  alias(libs.plugins.quarkus)
+  alias(libs.plugins.jandex)
+}
+
+dependencies {
+  implementation(project(":polaris-core"))
+  implementation(libs.commons.dbcp2)
+  implementation(libs.slf4j.api)
+
+  implementation("io.quarkus:quarkus-arc")
+  implementation(platform(libs.quarkus.bom))

Review Comment:
   I do not think these dependencies should be present in this module. What 
breaks if they are removed?



##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/ConnectionManager.java:
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.extension.persistence.relational.jdbc;
+
+import javax.sql.DataSource;
+import org.apache.commons.dbcp2.BasicDataSource;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class ConnectionManager {
+
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(ConnectionManager.class);
+
+  private DataSource dataSource;
+
+  public ConnectionManager(RelationalJdbcConfiguration jdbcConfiguration) {
+    this.dataSource = initializeDataSource(jdbcConfiguration);
+  }
+
+  private BasicDataSource initializeDataSource(RelationalJdbcConfiguration 
jdbcConfiguration) {
+    BasicDataSource bds = new BasicDataSource();

Review Comment:
   Why not use Quarkus infrastructure for managing the DataSource?
   
   Example: 
https://github.com/projectnessie/nessie/blob/54f983c0e611daa77686060cc2be35a40814ad57/servers/quarkus-common/src/main/java/org/projectnessie/quarkus/providers/storage/JdbcBackendBuilder.java#L121
   
   That part will be present only in the server (i.e. future code).
   
   Unit tests can, of course, use DBCP locally. WDYT? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to