dimas-b commented on code in PR #1229:
URL: https://github.com/apache/polaris/pull/1229#discussion_r2025285554


##########
bom/build.gradle.kts:
##########
@@ -33,6 +33,7 @@ dependencies {
     api(project(":polaris-immutables"))
     api(project(":polaris-misc-types"))
     api(project(":polaris-version"))
+    api(project(":polaris-persistence-varint"))

Review Comment:
   Fair enough. By that logic it might be best to keep `Varint` inside the 
(future) module that actually needs it (not separate jar artifacts). @snazy 
WDYT?
   
   If that works for everybody, and since this PR was reviewed, how about we 
merge it with renaming the module to `:polaris-persistenance-nosql-varint` and 
when the bulk of NoSQL persistence comes we'll fold it into the module that 
needs it? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to