eric-maynard commented on code in PR #1231:
URL: https://github.com/apache/polaris/pull/1231#discussion_r2010698315


##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1189,6 +1189,20 @@ private class BasePolarisTableOperations extends 
BaseMetastoreTableOperations {
       this.tableFileIO = defaultFileIO;
     }
 
+    protected PolarisResolvedPathWrapper getTablePath(TableIdentifier 
tableIdentifier) {

Review Comment:
   @dennishuo we previously spoke about the impact that using a separate entity 
type might have on how we interact with persistence. For these checks that need 
to check both for an Iceberg table and a generic table with the same 
TableIdentifier, does this make sense?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to