dimas-b commented on code in PR #1313:
URL: https://github.com/apache/polaris/pull/1313#discussion_r2031811156
##########
service/common/src/main/java/org/apache/polaris/service/persistence/InMemoryPolarisMetaStoreManagerFactory.java:
##########
@@ -100,10 +96,22 @@ public synchronized Supplier<TransactionalPersistence>
getOrCreateSessionSupplie
private void bootstrapRealmsAndPrintCredentials(List<String> realms) {
RootCredentialsSet rootCredentialsSet =
RootCredentialsSet.fromEnvironment();
- Map<String, PrincipalSecretsResult> results = this.bootstrapRealms(realms,
rootCredentialsSet);
+ this.bootstrapRealms(realms, rootCredentialsSet);
bootstrappedRealms.addAll(realms);
+ }
+ @Override
+ public Map<String, PrincipalSecretsResult> bootstrapRealms(
+ Iterable<String> realms, RootCredentialsSet rootCredentialsSet) {
+ Map<String, PrincipalSecretsResult> results =
super.bootstrapRealms(realms, rootCredentialsSet);
+
+ Map<String, RootCredentials> presetCredentials =
rootCredentialsSet.credentials();
for (String realmId : realms) {
+ if (presetCredentials.containsKey(realmId)) {
+ // Credentials provided in the runtime env... no need to print
Review Comment:
I'll wait another day in case someone else has a concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
