wolflex888 commented on code in PR #1164:
URL: https://github.com/apache/polaris/pull/1164#discussion_r2044987142
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##########
@@ -398,9 +398,18 @@ public Response loadTable(
.loadTableIfStale(tableIdentifier, ifNoneMatch, snapshots)
.orElseThrow(() -> new
WebApplicationException(Response.Status.NOT_MODIFIED));
} else {
+ String credentialsEndpoint =
+ String.format(
+ "/v1/%s/namespaces/%s/tables/%s/credentials",
+ prefix, tableIdentifier.namespace().toString(),
tableIdentifier.name());
response =
catalog
- .loadTableWithAccessDelegationIfStale(tableIdentifier,
ifNoneMatch, snapshots)
+ .loadTableWithAccessDelegationIfStale(
+ tableIdentifier,
+ ifNoneMatch,
+ snapshots,
+ delegationModes,
+ RESTUtil.decodeString(credentialsEndpoint))
Review Comment:
I see. does that mean we should be building the response here instead of
having a complete response returned from `loadTableAccessDelegationIfSTale`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
