dimas-b commented on code in PR #1401:
URL: https://github.com/apache/polaris/pull/1401#discussion_r2051145103
##########
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkStore.java:
##########
@@ -133,7 +133,7 @@ void deleteFromEntities(EntityManager session, long
catalogId, long entityId) {
diagnosticServices.check(session != null, "session_is_null");
checkInitialized();
- ModelEntity model = lookupEntity(session, catalogId, entityId);
+ ModelEntity model = lookupEntity(session, catalogId, entityId, -1);
Review Comment:
As far as I can tell all call paths to here come from
`AbstractTransactionalPersistence.deleteEntityInCurrentTxn()` which has the
entity's type code, so it could be propagated, I guess.
##########
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkStore.java:
##########
@@ -84,7 +84,7 @@ void writeToEntities(EntityManager session, PolarisBaseEntity
entity) {
diagnosticServices.check(session != null, "session_is_null");
checkInitialized();
- ModelEntity model = lookupEntity(session, entity.getCatalogId(),
entity.getId());
+ ModelEntity model = lookupEntity(session, entity.getCatalogId(),
entity.getId(), -1);
Review Comment:
Why not use `entity.getTypeCode()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
