adutra commented on code in PR #1411: URL: https://github.com/apache/polaris/pull/1411#discussion_r2052263187
########## site/content/in-dev/unreleased/metastores.md: ########## @@ -24,12 +24,11 @@ weight: 700 This page documents important configurations for connecting to a production database through [EclipseLink](https://eclipse.dev/eclipselink/). -## Building Polaris with EclipseLink +## Polaris EclipseLink Review Comment: FYI I'm still seeing a few occurrences of `-PeclipseLinkDeps=org.postgresql:postgresql:42.7.4` in the following pages: getting-started/eclipselink/README.md site/content/in-dev/unreleased/getting-started/quickstart.md site/content/in-dev/unreleased/admin-tool.md ########## helm/polaris/README.md.gotmpl: ########## @@ -71,7 +71,7 @@ Simply run the `run.sh` script from the Polaris repo root, making sure to specif `--eclipse-link-deps` option: ```bash -./run.sh --eclipse-link-deps=org.postgresql:postgresql:42.7.4 +./run.sh Review Comment: You need to run ```shell helm-docs --chart-search-root=helm ``` And commit the changes. ########## quarkus/server/distribution/LICENSE: ########## @@ -2167,6 +2173,12 @@ License (from POM): Apache License 2.0 - https://www.apache.org/licenses/LICENSE -------------------------------------------------------------------------------- +Group: org.eclipse.persistence Name: eclipselink Version: 4.0.6 +Project URL: https://eclipse.dev/eclipselink/ +License: Eclipse Public License 2.0 - https://projects.eclipse.org/license/epl-2.0 + +-------------------------------------------------------------------------------- + Group: org.glassfish.expressly Name: expressly Version: 5.0.0 Review Comment: We don't. have a mention of Postgres here, should we include one? ########## quarkus/server/distribution/LICENSE: ########## @@ -2086,6 +2086,12 @@ License (from POM): Apache License 2.0 - https://www.apache.org/licenses/LICENSE -------------------------------------------------------------------------------- +Group: org.eclipse.angus Name: angus-activation Version: 2.0.2 Review Comment: Just curious: this dependency comes from the Quarkus BOM, but it's not used in Polaris. Do we still need to include it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
