eric-maynard commented on code in PR #1414:
URL: https://github.com/apache/polaris/pull/1414#discussion_r2052707742
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/LocalPolarisMetaStoreManagerFactory.java:
##########
@@ -237,22 +236,11 @@ private PrincipalSecretsResult
bootstrapServiceAndCreatePolarisPrincipalForRealm
PolarisEntityType.PRINCIPAL,
PolarisEntitySubType.NULL_SUBTYPE,
PolarisEntityConstants.getRootPrincipalName());
- PolarisPrincipalSecrets secrets =
- metaStoreManager
- .loadPrincipalSecrets(
- polarisContext,
- PolarisEntity.of(rootPrincipalLookup.getEntity())
- .getInternalPropertiesAsMap()
- .get(PolarisEntityConstants.getClientIdPropertyName()))
- .getPrincipalSecrets();
- PrincipalSecretsResult rotatedSecrets =
Review Comment:
I'm a little surprised no tests need to change for this to pass!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
