andrew4699 commented on code in PR #1193:
URL: https://github.com/apache/polaris/pull/1193#discussion_r2056407900
##########
polaris-core/src/test/java/org/apache/polaris/core/persistence/cache/EntityCacheTest.java:
##########
@@ -102,14 +102,14 @@ public EntityCacheTest() {
/**
* @return new cache for the entity store
*/
- EntityCache allocateNewCache() {
- return new EntityCache(this.metaStoreManager);
+ InMemoryEntityCache allocateNewCache() {
+ return new InMemoryEntityCache(this.metaStoreManager);
}
@Test
void testGetOrLoadEntityByName() {
// get a new cache
- EntityCache cache = this.allocateNewCache();
+ InMemoryEntityCache cache = this.allocateNewCache();
Review Comment:
The InMemoryEntityCache has custom methods that let you observe its state:
getEntityById/Name. These are not required in the interface but are useful for
testing. EntityCacheTest is really a test of the InMemoryEntityCache. I've gone
ahead and renamed it.
##########
polaris-core/src/testFixtures/java/org/apache/polaris/core/persistence/BaseResolverTest.java:
##########
@@ -57,7 +57,7 @@ public abstract class BaseResolverTest {
protected PolarisBaseEntity P1;
// cache we are using
- protected EntityCache cache;
+ protected InMemoryEntityCache cache;
Review Comment:
https://github.com/apache/polaris/pull/1193#discussion_r2056407900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
