flyrain commented on code in PR #1430:
URL: https://github.com/apache/polaris/pull/1430#discussion_r2056418992
##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -696,7 +701,7 @@ public PolarisPrincipalSecrets rotatePrincipalSecrets(
e.getMessage(),
e);
throw new RuntimeException(
- String.format("Failed to rotatePrincipalSecrets for clientId: %s",
clientId));
+ String.format("Failed to rotatePrincipalSecrets for clientId: %s",
clientId), e);
Review Comment:
Does this leak sensitive information to the REST clients?
##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -122,7 +122,7 @@ public void writeEntity(
}
} catch (SQLException e) {
throw new RuntimeException(
- String.format("Failed to write entity due to %s", e.getMessage()));
+ String.format("Failed to write entity due to %s", e.getMessage()),
e);
Review Comment:
I'd recommend to introduce a new exception for JDBC implementation instead
of using the general one `RuntimeException`. We may name it like
`JdbcPersistenceException`, which extend `RuntimeException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
