eric-maynard commented on code in PR #1426:
URL: https://github.com/apache/polaris/pull/1426#discussion_r2057104051
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1203,6 +1215,77 @@ private class BasePolarisTableOperations extends
BaseMetastoreTableOperations {
}
@Override
+ public TableMetadata current() {
+ if (shouldRefresh) {
+ return refresh();
+ }
+ return currentMetadata;
+ }
+
+ @Override
+ public TableMetadata refresh() {
Review Comment:
+1 on getting @jbonofre's POV here
As for making this a top-level class (file) I would love to do so. However,
these classes are tightly coupled with `IcebergCatalog` right now and rely on
its private members and methods. The refactor gets significantly more
complicated when done that way. So, I decided to try this smaller, more
incremental, change which is what's actually needed to unblock the behavior
proposed in #1378.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
