flyrain commented on code in PR #1371: URL: https://github.com/apache/polaris/pull/1371#discussion_r2059369307
########## extension/persistence/relational-jdbc/src/main/resources/postgres/schema-v1.sql: ########## @@ -15,16 +15,12 @@ -- KIND, either express or implied. See the License for the -- specific language governing permissions and limitations -- under the License. --- --- Note: Database and schema creation is not included in this script. Please create the database and --- schema before running this script. for example in psql: --- CREATE DATABASE polaris_db; --- \c polaris_db --- CREATE SCHEMA polaris_schema; --- set search_path to polaris_schema; +CREATE SCHEMA IF NOT EXISTS POLARIS_SCHEMA; +SET search_path TO POLARIS_SCHEMA; CREATE TABLE IF NOT EXISTS entities ( + realm_id TEXT NOT NULL, Review Comment: Minor concern: the length of a TEXT is unbounded. It performs not well in case of a long string, esp. it's a PK, could be part of join. Should we limit its length? We don't have to do at the schema level though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
