adnanhemani commented on code in PR #1452: URL: https://github.com/apache/polaris/pull/1452#discussion_r2059389417
########## site/content/in-dev/unreleased/getting-started/quickstart.md: ########## @@ -72,28 +72,21 @@ cd ~/polaris You should see output for some time as Polaris builds and starts up. Eventually, you won’t see any more logs and should see messages that resemble the following: ``` -realm: <realm> root principal credentials: <client-id>:<client-secret> INFO [io.quarkus] [,] [,,,] (Quarkus Main Thread) polaris-quarkus-service <version> on JVM (powered by Quarkus <version>) started in 2.656s. Listening on: http://localhost:8181. Management interface listening on http://0.0.0.0:8182. INFO [io.quarkus] [,] [,,,] (Quarkus Main Thread) Profile prod activated. Live Coding activated. INFO [io.quarkus] [,] [,,,] (Quarkus Main Thread) Installed features: [...] ``` At this point, Polaris is running. -When using a Gradle-launched Polaris instance in this tutorial, we'll launch an instance of Polaris that stores entities only in-memory. This means that any entities that you define will be destroyed when Polaris is shut down. It also means that Polaris will automatically bootstrap itself with root credentials. For more information on how to configure Polaris for production usage, see the [docs]({{% relref "../configuring-polaris-for-production" %}}). - -When Polaris is launched using an in-memory metastore, the root principal credentials can be found -in stdout on initial startup. Look for a line that resembles the following: - -``` -realm: <realm> root principal credentials: <client-id>:<client-secret> -``` - -Be sure to take note of these credentials as we'll be using them below. You can also set these credentials as environment variables for use with the Polaris CLI: +When using a Gradle-launched Polaris instance in this tutorial, we'll launch an instance of Polaris that stores entities only in-memory. This means that any entities that you define will be destroyed when Polaris is shut down. +For more information on how to configure Polaris for production usage, see the [docs]({{% relref "../configuring-polaris-for-production" %}}). +Unless explicitly specified, Polaris will start with pre-configured credentials for the root principal credentials. These credentials can be found within the [code](https://github.com/apache/polaris/blame/6308ba02e89236a72e8661ca0e4d7494ee3ff946/quarkus/server/build.gradle.kts#L82). Review Comment: > Also references to a specific commit of source code in docs are likely to go stale and become misleading as the code evolves. > Why not say that when Polaris is lauched by ./gradlew run the credentials are root:secret? This is fair. I was attempting to future-proof this in case we did make a change at some point, but this is a permalink and therefore, isn't future-proofed to begin with. Let me simplify it. > When credentials are not specified and env. var or system properties, there are no other "pre-configured" credentials. From my reading of the code, we have made the `root:secret` credentials the default by adding it as a default JVM argument when using `quarkusRun`. To me, I see this is a pre-configured credential. Am I misunderstanding this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
