sfc-gh-yzou commented on code in PR #1454:
URL: https://github.com/apache/polaris/pull/1454#discussion_r2059521948


##########
regtests/t_spark_sql/ref/spark_sql_s3.sh.ref:
##########
@@ -1,4 +1,4 @@
-{"defaults":{"default-base-location":"s3://datalake-storage-team/polaris_test/spark_sql_s3_catalog"},"overrides":{"prefix":"spark_sql_s3_catalog"},"endpoints":["GET
 /v1/{prefix}/namespaces","GET /v1/{prefix}/namespaces/{namespace}","POST 
/v1/{prefix}/namespaces","POST 
/v1/{prefix}/namespaces/{namespace}/properties","DELETE 
/v1/{prefix}/namespaces/{namespace}","GET 
/v1/{prefix}/namespaces/{namespace}/tables","GET 
/v1/{prefix}/namespaces/{namespace}/tables/{table}","POST 
/v1/{prefix}/namespaces/{namespace}/tables","POST 
/v1/{prefix}/namespaces/{namespace}/tables/{table}","DELETE 
/v1/{prefix}/namespaces/{namespace}/tables/{table}","POST 
/v1/{prefix}/tables/rename","POST 
/v1/{prefix}/namespaces/{namespace}/register","POST 
/v1/{prefix}/namespaces/{namespace}/tables/{table}/metrics","GET 
/v1/{prefix}/namespaces/{namespace}/views","GET 
/v1/{prefix}/namespaces/{namespace}/views/{view}","POST 
/v1/{prefix}/namespaces/{namespace}/views","POST 
/v1/{prefix}/namespaces/{namespace}/views/{view}","
 DELETE /v1/{prefix}/namespaces/{namespace}/views/{view}","POST 
/v1/{prefix}/views/rename","POST /v1/{prefix}/transactions/commit"]}
+{"defaults":{"default-base-location":"s3://test_bucket/polaris_test/spark_sql_s3_catalog"},"overrides":{"prefix":"spark_sql_s3_catalog"},"endpoints":["GET
 /v1/{prefix}/namespaces","GET /v1/{prefix}/namespaces/{namespace}","HEAD 
/v1/{prefix}/namespaces/{namespace}","POST /v1/{prefix}/namespaces","POST 
/v1/{prefix}/namespaces/{namespace}/properties","DELETE 
/v1/{prefix}/namespaces/{namespace}","GET 
/v1/{prefix}/namespaces/{namespace}/tables","GET 
/v1/{prefix}/namespaces/{namespace}/tables/{table}","HEAD 
/v1/{prefix}/namespaces/{namespace}/tables/{table}","POST 
/v1/{prefix}/namespaces/{namespace}/tables","POST 
/v1/{prefix}/namespaces/{namespace}/tables/{table}","DELETE 
/v1/{prefix}/namespaces/{namespace}/tables/{table}","POST 
/v1/{prefix}/tables/rename","POST 
/v1/{prefix}/namespaces/{namespace}/register","POST 
/v1/{prefix}/namespaces/{namespace}/tables/{table}/metrics","POST 
/v1/{prefix}/transactions/commit","GET 
/v1/{prefix}/namespaces/{namespace}/views","GET /v1/{prefix}/namespaces/{
 namespace}/views/{view}","HEAD 
/v1/{prefix}/namespaces/{namespace}/views/{view}","POST 
/v1/{prefix}/namespaces/{namespace}/views","POST 
/v1/{prefix}/namespaces/{namespace}/views/{view}","DELETE 
/v1/{prefix}/namespaces/{namespace}/views/{view}","POST 
/v1/{prefix}/views/rename","POST /v1/{prefix}/transactions/commit","GET 
polaris/v1/{prefix}/namespaces/{namespace}/generic-tables","POST 
polaris/v1/{prefix}/namespaces/{namespace}/generic-tables","DELETE 
polaris/v1/{prefix}/namespaces/{namespace}/generic-tables/{generic-table}","GET 
polaris/v1/{prefix}/namespaces/{namespace}/generic-tables/{generic-table}"]}

Review Comment:
   @collado-mike I have non-blocking question, the generic table api change has 
been in for long time, but our CI has never failing for this. does it mean this 
test is never run in the CI? does our release test do something different that 
captures this fail?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to