gh-yzou commented on code in PR #1438:
URL: https://github.com/apache/polaris/pull/1438#discussion_r2060818410
##########
service/common/src/main/java/org/apache/polaris/service/catalog/policy/PolicyCatalogHandler.java:
##########
@@ -72,6 +73,8 @@ public PolicyCatalogHandler(
@Override
protected void initializeCatalog() {
+ FeatureConfiguration.enforceFeatureEnabledOrThrow(
+ callContext, FeatureConfiguration.ENABLE_POLICY_STORE);
Review Comment:
Yeah, we can do those change in follow up prs. @HonahX if you are doing
those, just make sure you do the two things in separate PRs: one for move the
check to a early step ( if you can also help fix the call for prefix for
generic table that would be great), and another one to fix the regression tests.
##########
service/common/src/main/java/org/apache/polaris/service/catalog/policy/PolicyCatalogHandler.java:
##########
@@ -72,6 +73,8 @@ public PolicyCatalogHandler(
@Override
protected void initializeCatalog() {
+ FeatureConfiguration.enforceFeatureEnabledOrThrow(
+ callContext, FeatureConfiguration.ENABLE_POLICY_STORE);
Review Comment:
Yeah, we can do those change in follow up prs. @HonahX if you are doing
those, just make sure you do the two things in separate PRs: one for move the
check to a early step ( if you can also help fix the call for prefix for
generic table that would be great), and another one to fix the regression
tests. let me know what is your plan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
