MonkeyCanCode commented on PR #1474: URL: https://github.com/apache/polaris/pull/1474#issuecomment-2833730469
> Overall I think the idea here is pretty cool. One thing I would like to see is the ability to "extract" a setup from an existing deployment. That doesn't necessarily have to happen in the first iteration. > > One thing I _do_ think we need to examine more closely is how principal creation will happen and how the secrets will be managed. > > This also sort of gets into the same territory as using the [sync tool](https://github.com/apache/polaris-tools/tree/main/polaris-synchronizer) to dump to a file and then load from the file. So the sync tool is mainly for migration purpose I think where a end-user will need to have the setup first to be able to use that. And yes, I do plan to get a `dump` option to dump existed entities into a setup config (assuming we will proceed with this route). The main purpose for this PR is to allow people to define and bootstrap their environments via a config. For example, assuming I have dev, stage, and prod and I want the basic entities (e.g. principal, principal role, catalog role, and privileges to be the same), I can easily copy/paste the config and change the location refs for catalog. Then for adding in new entities, I will then be able to do this via PR then have github action to continue run this setup command (as if the entities already existed, it will just skip). The one thing I am debating myself is support update/delete operations. For update, it is mainly we will need to run a bit more commands to check status then update each of them accordingly (do-able but maybe a bit costly?). For delete, the only catches I can think about we can't delete default catalog admin role and we can't safely drop a catalog as it may have tables/views refs as well other entities that are created outside this command. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
