singhpk234 commented on code in PR #1482:
URL: https://github.com/apache/polaris/pull/1482#discussion_r2064799251
##########
quarkus/admin/src/main/java/org/apache/polaris/admintool/config/QuarkusProducers.java:
##########
@@ -76,4 +81,9 @@ public PolarisConfigurationStore configurationStore() {
// A configuration store is not required when running the admin tool.
return new PolarisConfigurationStore() {};
}
+
+ @Produces
+ public JdbcDatasource jdbcDatasource(@ConfigProperty(name =
"polaris.persistence.realm.isolation.type") String realmIsolationType, @All
List<InstanceHandle<DataSource>> dataSources) {
Review Comment:
I see so essentially having this mapping without an explicit config to
support 3 use case :
for ex consider realm1, realm2, realm3
1. realm1, realm2, realm3 are 1 DB each
2. realm1, realm2, realm3 are 1 DB and each table has 3 realms (as PK)
3. realm 1 can be DB realm2 and realm3 can be just 1 DB and each table as 2
PK
where as having a config which decides the isolation level just allows :
case 1, 2
Thoughts ? i think having config like that reduces un-intentional error
test
##########
quarkus/admin/src/main/java/org/apache/polaris/admintool/config/QuarkusProducers.java:
##########
@@ -76,4 +81,9 @@ public PolarisConfigurationStore configurationStore() {
// A configuration store is not required when running the admin tool.
return new PolarisConfigurationStore() {};
}
+
+ @Produces
+ public JdbcDatasource jdbcDatasource(@ConfigProperty(name =
"polaris.persistence.realm.isolation.type") String realmIsolationType, @All
List<InstanceHandle<DataSource>> dataSources) {
Review Comment:
I see so essentially having this mapping without an explicit config to
support 3 use case :
for ex consider realm1, realm2, realm3
1. realm1, realm2, realm3 are 1 DB each
2. realm1, realm2, realm3 are 1 DB and each table has 3 realms (as PK)
3. realm 1 can be DB realm2 and realm3 can be just 1 DB and each table as 2
PK
where as having a config which decides the isolation level just allows :
case 1, 2
Thoughts ? i think having config like that reduces un-intentional error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
