flyrain commented on code in PR #1493:
URL: https://github.com/apache/polaris/pull/1493#discussion_r2069427772
##########
quarkus/server/build.gradle.kts:
##########
@@ -91,7 +91,7 @@ distributions {
from(project.layout.buildDirectory.dir("quarkus-app"))
from("distribution/NOTICE")
from("distribution/LICENSE")
- exclude("lib/main/io.quarkus.quarkus-container-image*")
Review Comment:
The `quarkus-container-image-docker` is actually not needed at compile time.
There is no compile time dependency on it. This is verified by my test by just
removing it. It's needed and only needed at runtime per my test. With that,
marking it as `runtimeOnly` is reasonable. The only problem here is that the
packaging task doesn't pick runtimeOnly dependencies, that's why I propose to
customize a bit to include it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
