adutra commented on code in PR #1482: URL: https://github.com/apache/polaris/pull/1482#discussion_r2069548146
########## quarkus/admin/src/main/resources/application.properties: ########## @@ -49,3 +49,21 @@ quarkus.index-dependency.guava.group-id=com.google.guava quarkus.index-dependency.guava.artifact-id=guava quarkus.index-dependency.protobuf.group-id=com.google.protobuf quarkus.index-dependency.protobuf.artifact-id=protobuf-java + +#quarkus.datasource.db-kind=pgsql +#quarkus.datasource.jdbc.url=polaris +#quarkus.datasource.username=polaris +#quarkus.datasource.password=polaris +quarkus.datasource.\"realm1_ds\".db-kind=pgsql Review Comment: > If quarkus.datasource.\"realm1_ds\".db-kind=pgsql has to be defined at build time, that will be a problem for users of the binary distribution, I guess. See https://quarkus.io/guides/datasource#configure-multiple-datasources: > Even when only one database extension is installed, named databases need to specify at least one build-time property so that Quarkus can detect them. Generally, this is the db-kind property [...] This is why I asked this question, I think there is some misunderstanding going on: https://github.com/apache/polaris/pull/1482#issuecomment-2843429552 > I'm surprised this is required, because the default datasource does not have to be defined at build time, if I'm not mistaken. The default datasource is treated slightly different: if `db-kind` is missing, the JDBC driver will be guessed from the available JDBC drivers. But that doesn't help here, since the intent is to use many named datasources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
