XJDKC commented on PR #1347: URL: https://github.com/apache/polaris/pull/1347#issuecomment-2845254530
Hey Eric, I pulled your branch and tested locally, I found several issues: 1. Why don't we update the generated tests as well? I also find the tests are not updated if we rerun the tests 2. We have one test that was written by use, the polaris cli test 3. If the spec add some new models, these new files are not managed by git, so the script won't add headers to these new files. We need to add them and rerun the script. 4. Some file types don't have a corresponding header file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
