dimas-b commented on code in PR #1356:
URL: https://github.com/apache/polaris/pull/1356#discussion_r2070922278
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/InMemoryEntityCache.java:
##########
@@ -76,15 +77,22 @@ public InMemoryEntityCache(@Nonnull PolarisMetaStoreManager
polarisMetaStoreMana
};
long weigherTarget =
-
PolarisConfiguration.loadConfig(FeatureConfiguration.ENTITY_CACHE_WEIGHER_TARGET);
+ polarisCallContext
+ .getConfigurationStore()
Review Comment:
but TBH, I'd really like to use CDI (with custom producers) for injection
rather than relying on factories in the main call path. In other words, I'd
like the main body of code to receive dependent objects through injection and
factories / producers to be removed from the main call paths and be engaged by
CDI when request-handlers are constructed.
All-in-all, the intention behind this PR seems to be pointing in that
direction, so why not do the CDI-based refactoring now and then perhaps the
config loading issue is solved automatically?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
