adutra commented on code in PR #1489:
URL: https://github.com/apache/polaris/pull/1489#discussion_r2071845328
##########
polaris-core/src/main/java/org/apache/polaris/core/connection/OAuthClientCredentialsParametersDpo.java:
##########
@@ -86,7 +86,7 @@ public OAuthClientCredentialsParametersDpo(
return clientSecretReference;
}
- public @Nonnull List<String> getScopes() {
+ public @Nullable List<String> getScopes() {
Review Comment:
This change sounds odd, probably unwanted?
##########
spec/polaris-management-service.yml:
##########
@@ -938,6 +940,34 @@ components:
format: password
description: Bearer token (input-only)
+ SigV4AuthenticationParameters:
+ type: object
+ description: AWS Signature Version 4 authentication
+ allOf:
+ - $ref: '#/components/schemas/AuthenticationParameters'
+ properties:
+ roleArn:
+ type: string
+ description: The aws IAM role arn assume when signing requests
Review Comment:
```suggestion
description: The aws IAM role arn to assume when signing requests
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
