singhpk234 commented on code in PR #1506: URL: https://github.com/apache/polaris/pull/1506#discussion_r2072076215
########## spec/polaris-management-service.yml: ########## @@ -938,6 +940,34 @@ components: format: password description: Bearer token (input-only) + SigV4AuthenticationParameters: + type: object + description: AWS Signature Version 4 authentication + allOf: + - $ref: '#/components/schemas/AuthenticationParameters' + properties: + roleArn: + type: string + description: The aws IAM role arn assume when signing requests + example: "arn:aws:iam::123456789001:role/role-that-has-remote-catalog-access" + externalId: + type: string + description: An optional external id used to establish a trust relationship with AWS in the trust policy + signingRegion: + type: string + description: Region to be used by the SigV4 protocol for signing requests Review Comment: explicit would be helpful ! Thanks @XJDKC -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org