adutra commented on code in PR #1514:
URL: https://github.com/apache/polaris/pull/1514#discussion_r2072123914


##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisPolicyServiceIntegrationTest.java:
##########
@@ -372,7 +372,14 @@ public void testPolicyMapping() {
 
     restCatalog
         .buildTable(
-            NS2_T1, new Schema(Types.NestedField.of(1, true, "string", 
Types.StringType.get())))
+            NS2_T1,
+            new Schema(
+                Types.NestedField.builder()

Review Comment:
   There is `org.apache.iceberg.types.Types.NestedField#optional(int, 
java.lang.String, org.apache.iceberg.types.Type)` as well, I was told to use 
that instead of the builder (contrary to what the javadocs say).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to