singhpk234 commented on code in PR #1515:
URL: https://github.com/apache/polaris/pull/1515#discussion_r2074297907
##########
site/content/in-dev/unreleased/admin-tool.md:
##########
@@ -74,14 +74,7 @@ The Polaris Admin Tool must be executed with the same
configuration as the Polar
configuration can be done via environment variables or system properties.
At a minimum, it is necessary to configure the Polaris Admin Tool to connect
to the same database
-used by the Polaris server. This can be done by setting the following system
properties:
-
-```shell
-java \
-
-Dpolaris.persistence.eclipselink.configuration-file=/path/to/persistence.xml \
- -Dpolaris.persistence.eclipselink.persistence-unit=polaris \
- -jar quarkus/admin/build/polaris-quarkus-admin-*-runner.jar
-```
+used by the Polaris server.
Review Comment:
yes, but the immediate line below re-directs the user to move to
metastore.md page to configure the metastore, so this was kind a redundant.
Hence removed.
##########
quarkus/admin/src/testFixtures/java/org/apache/polaris/admintool/PostgresTestResourceLifecycleManager.java:
##########
@@ -63,7 +63,10 @@ public Map<String, String> start() {
context.containerNetworkId().ifPresent(postgres::withNetworkMode);
postgres.start();
return Map.of(
- "polaris.persistence.eclipselink.configuration-file",
createPersistenceXml().toString());
+ "polaris.persistence.type",
+ "eclipse-link",
Review Comment:
> Let's add a separate test profile for EclipseLink then and run maybe a
sub-set of tests. How about the bootstrap test in the admin tool and the REST
API test in the quarkus server?
This profile is just used for eclipse link, the jdbc profile and lifecycle
manager is is present is quarkus/test-commons. The reason why i kept both
together is i we are deprecating eclipse link via doc and not via code, so
hence updating default is in the same PR. Please Let me know your thoughts
considering above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
