singhpk234 commented on code in PR #1517: URL: https://github.com/apache/polaris/pull/1517#discussion_r2078723320
########## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/RelationalJdbcConfiguration.java: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.extension.persistence.relational.jdbc; + +import io.smallrye.config.ConfigMapping; +import java.util.Optional; + +@ConfigMapping(prefix = "polaris.persistence.relational.jdbc") Review Comment: > @ConfigMapping conveys certain expectation as to how the config values can be provided, but the JDBC module alone does not have a runtime component that provides those values. Thats certainly one way to look at it other is to look at it in the perspective of every runtime should have consistent config name irrespective if it's spring boot or quarkus having a conf in this module we define it for consistency. Nevertheless i believe you feel more strongly about this pattern and I totally respect that, than i think of the other pattern. Hence i made the changes to make them in separate module ! Again i am very new to quarkus ! may be this is a well established pattern in these frameworks, hence I might not be able to get it, thank you so much for patiently explaining ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
